Clean up in each_child_of_item
#80646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Jan 3, 2021
|
r? @petrochenkov @bors r+ rollup |
|
📌 Commit 4d3227f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#80580 (Add suggestion for "ignore" doc code block) - rust-lang#80591 (remove allow(incomplete_features) from std) - rust-lang#80617 (Detect invalid rustdoc test commands) - rust-lang#80628 (reduce borrowing and (de)referencing around match patterns (clippy::match_ref_pats)) - rust-lang#80646 (Clean up in `each_child_of_item`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopes to eliminate some of the surprising elements I encountered while reading the function.
macros_onlyis checked against inside the loop body, but if it istrue, the loop is skipped anywayspanwhen relevant